[U-Boot] [PATCH v4 2/8] ARM: add secure monitor handler to switch to non-secure state
Tom Rini
trini at ti.com
Tue Aug 27 14:11:25 CEST 2013
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 08/27/2013 05:51 AM, Andre Przywara wrote:
> On 08/27/2013 02:23 AM, Masahiro Yamada wrote:
>> Hello Andre,
>>
>>> +/* the vector table for secure state */ +_monitor_vectors: +
>>> .word 0 /* reset */ + .word 0 /* undef */ + adr pc,
>>> _secure_monitor + .word 0 + .word 0 + .word 0 +
>>> .word 0 + .word 0 + .word 0 /* pad */
>>
>> Could you explain why the last line is needed?
>
> I guess I cannot explain because it's probably not needed ;-) I
> copied this from somewhere else and accidentally this padding
> somehow sneaked in (from the actual addresses array, where the
> start vector was missing and thus the array ended at 7 * 4 bytes)
>
> Do we need another version or is a follow-up patch sufficient? I'd
> like to avoid another review round for the sake of the reviewers.
Lets do a follow-up and Albert can squash it if desired.
- --
Tom
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iQIcBAEBAgAGBQJSHJdtAAoJENk4IS6UOR1WDgcP/1Rz+1U/La9brudy9OyjeVqT
FYdWMtFr/TGELkoaUX/saY/MZoIPBpCO4iW8y5UvQJ3cQAm5WqgPK4/ku3wcbYC6
yaVC91fQ9UQEqzmUBCRGZAGwJuZ+JiElP/9wmqEi7RvnQTYimRYkEpm+XgxRkuX0
l3HH5QLyTO8CbQ4FKm8XeE0JeMfpNqPflMo5oDNMVlWC7a4VXMP49uIGoYt6emPp
d7US4neOZRgL0ANiC/WoV807otl+llFRgZ0zqM7A60th+jJ2YqJIyZlp6QnL2r+Z
YDLlKSvwBliYlmdFWFxxfUoe+4qK27HrOA39PP/Cj5ocQCoEzIRZFTXhlV3AeB9L
CEhXgImSs0BS4AxN7CPdaJLdDGalphthkHOuGP66m+Xb9k7v6gmdNhphusX01FhC
UUgRRKVUT02dS+51tMRxk1wdy805eI6zo34hmvS2SmWWuxAM1kCQhphUl+Ib1ew6
H7V+XoDdOp+iQzABB86TL8J8KtoUgiVA81NqQsvbiW4pR5rUoxBhTTXEYOnZyMYA
qypDCyYepuQCLtz5kxxe0b1Y4tmZsNKtnVuMA55LtPVLHqX1uJ/vXXHBTsO3rGG3
Rz3BTq0o9GVYBg6YLJh496qD8kzqOfnhpu3U+5Fc10H0ldlDcs8YhLU+hzVD+nLD
dDuxa9OzgPsEK/Wc1mWg
=5MkM
-----END PGP SIGNATURE-----
More information about the U-Boot
mailing list