[U-Boot] [PATCH v3 0/5] mtd: nand: omap: optimize and clean-up of OMAP NAND driver

[Tom Rini]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 08/29/2013 01:26 PM, Gupta, Pekon wrote:
>>
>> On Thu, Aug 29, 2013 at 04:26:40PM +0530, Pekon Gupta wrote:
>>> *changes in v3*
>>> [PATCH 1/5] (complete change)
>>> 	- ecc-scheme is selection is controller by s/w, not CONFIG_NAND_xx
>>> 	- added omap_select_ecc_scheme(), as common function to handle
>> all
>>> 	  ecc-scheme related configurations for both board_nand_init() &
>>> 	  omap_nand_switch_ecc().
>>> 	- removed un-used defines from asm/arch-am33xx/omap_gpmc.h
>>> 	- updated doc/REAME.nand
>>> [PATCH 2/5] removed un-used defines from asm/omap_gpmc.h
>>> [PATCH 3/5] removed omap_calculate_ecc_bch_sw() and
>> omap_calculate_ecc()
>>> 		and merged their logic into omap_calculate_ecc_bch()
>>> [PATCH 4/5] updated return error-code in-case of invalid conditions
>>> [PATCH 5/5] (new) for board/ti/am335x/README
>>
>> Note that with the series applied, we see:
>> NAND:  nand: selected OMAP_ECC_BCH8_CODE_HW
>> 256 MiB
>>
> The first part of string "NAND:   " is coming from 
> arch/arm/lib/board.c:582 	puts("NAND:  ");
> I'm not sure why it was added, seems legacy code..
> And same is copied to all other arch/xx/lib/board.c
> However as this print is not giving much of info, so can this be removed ?

NAND + size is useful information.

>> I think we should move the selected message to a debug().
>>
> Second part of string "nand: selected OMAP_ECC_BCH8_CODE_HW" was
> specifically added in board_nand_init() because currently there is no way
> to identify the ECC scheme being used in u-boot. Unless digging into
>  source code and reviewing board file.
> And many time end-users face ECC scheme mis-match between u-boot
> and linux when flashing kernel and file-system from u-boot.
> Thus this print helps in identifying the ECC scheme being used from logs.
> So, please keep this print "nand: selected <ecc-scheme>" ..  ?

I'd rather not as we should have left the mis-match problems in the
past.  We don't generally offer commands to switch ECC schemes as
everyone is using the same now.  When we do need to offer switching for
legacy reasons that's when we should say what we're on.

- -- 
Tom
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJSH4ksAAoJENk4IS6UOR1W208QAJkXCvdm1gsIB7vjL8zf4Yi8
CGNm7B2d5K1kubP21LzClgf52T5ImMFlqXpvJJ/BPjwEnanPS6zXeBrzc1zRZZft
Y8Q6VlnPl094zDof9TdEoa51L6XmRqc8zRcdELvJLatrw0fd2htuJrXdUgi46a3M
MeukhTHWT0IkbOixFuI22eiaN8YC5api5ljZvMcNJMXXkCbcgb0C743BPiRHasFI
nslOhfJShU/XhNuhtOqKnN6oen5nuzYi7O2DFPS55ipkiz+ekKon8pVU587WXtTW
ML5Hb+8tutgkZwhMXG0tWKaLv7Bhk9zKPmfLAyqJrdOulGeIRxRRVBrI0Vi9kcJ4
a6dO2g3+zOyNkZ//ejIjFvVNRBCK1+eSPxY0KxNATIghn4IuGLC2tGB1BUap2+hR
odBZzgETLcomyzpLnVOCMl+FVCPaAE0qKsqdz3h6O+qPYY+bSIFyzTJNioj7d2ws
LADJoR5FM+rTo8/mQrsQwbGT2sMPENeeLYrjSkKRMBLQonItp5SOyZPMPUwp42sx
Ih6tmvZkQM4sWt2okAZltOhbtzx8uPmKDKsE8UIZKB4uF4okP86SjsidguUhj2g6
NmutHKNiwcz4Pppe9IhigusgL9TrVMTSq4yefzOeLY2iKnouqog1RCevdly2BQaZ
iqbOYt1DuccSoIzat68h
=aNQx
-----END PGP SIGNATURE-----