[U-Boot] [PATCH] cmd_mem.c: Fix simple typoes, no functional changes.
Jeroen Hofstee
jeroen at myspectrum.nl
Sat Feb 2 20:23:53 CET 2013
On 02/02/2013 05:04 PM, Robert P. J. Day wrote:
> Signed-off-by: Robert P. J. Day <rpjday at crashcourse.ca>
>
> ---
>
> based on perusal of entire file as i was reading code. undoubtedly
> more of these file-wide proofreads coming if no objections ...
>
> diff --git a/common/cmd_mem.c b/common/cmd_mem.c
> index 0f3ffc8..2568c04 100644
> --- a/common/cmd_mem.c
> +++ b/common/cmd_mem.c
> @@ -462,7 +462,7 @@ static int do_mem_loop(cmd_tbl_t *cmdtp, int flag, int argc,
> if (argc < 3)
> return CMD_RET_USAGE;
>
> - /* Check for a size spefication.
> + /* Check for a size specification.
> * Defaults to long if no or incorrect specification.
> */
> if ((size = cmd_get_data_size(argv[0], 4)) < 0)
> @@ -531,7 +531,7 @@ int do_mem_loopw (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
> if (argc < 4)
> return CMD_RET_USAGE;
>
> - /* Check for a size spefication.
> + /* Check for a size specification.
> * Defaults to long if no or incorrect specification.
> */
> if ((size = cmd_get_data_size(argv[0], 4)) < 0)
> @@ -683,7 +683,7 @@ static int do_mem_mtest(cmd_tbl_t *cmdtp, int flag, int argc,
> * Data line test: write a pattern to the first
> * location, write the 1's complement to a 'parking'
> * address (changes the state of the data bus so a
> - * floating bus doen't give a false OK), and then
> + * floating bus doesn't give a false OK), and then
> * read the value back. Note that we read it back
> * into a variable because the next time we read it,
> * it might be right (been there, tough to explain to
> @@ -747,7 +747,7 @@ static int do_mem_mtest(cmd_tbl_t *cmdtp, int flag, int argc,
> * 1's test on the relevant bits of the
> * address and checking for aliasing.
> * This test will find single-bit
> - * address failures such as stuck -high,
> + * address failures such as stuck-high,
> * stuck-low, and shorted pins. The base
> * address and size of the region are
> * selected by the caller.
>
nitpicking: the summary line should not end with a dot.
multi line comments in u-boot are commonly
/*
* I span
* multiple lines
*/
So while at it, you might want to add the empty opening line as well.
Regards,
Jeroen
More information about the U-Boot
mailing list