[U-Boot] [PATCH] cmd_mem.c: Fix simple typoes, no functional changes.

Robert P. J. Day rpjday at crashcourse.ca
Sun Feb 3 11:23:21 CET 2013


On Sun, 3 Feb 2013, Wolfgang Denk wrote:

> Dear Robert,
>
> In message <alpine.DEB.2.02.1302030404210.5835 at oneiric> you wrote:
> >
> > > multi line comments in u-boot are commonly
> > >
> > > /*
> > >  * I span
> > >  * multiple lines
> > >  */
> > >
> > > So while at it, you might want to add the empty opening line as well.
> >
> >   in cases like this, it's kind of a judgment call.  if that's truly a
> > strict standard, then sure.  but i'm pretty sure there's a *lot* of
> > the above type of comment in the source and when i'm just fixing
> > comments, i prefer to make as unobtrusive a change as possible.
>
> If you are editing these, then please also fix the multi-line comment
> style as suggested.  Thanks.

  so what is the actual standard?  besides the above, line space
above?  line space below?  because i see all sorts of variations in
the code, the most common of which is:

... snip ...
static int mod_mem(cmd_tbl_t *, int, int, int, char * const []);

/* Display values from last command.
 * Memory modify remembered values are different from display memory.
 */
static uint     dp_last_addr, dp_last_size;
... snip ...

which, as you can see, has a leading blank line but not a following
one.  so what's correct?  is this written down somewhere?

rday

-- 

========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================



More information about the U-Boot mailing list