[U-Boot] [PATCH 0/5] Create an API for safely accessing BMP header fields

Albert ARIBAUD albert.u.boot at aribaud.net
Mon Feb 4 15:19:56 CET 2013


Hi Nikita,

On Mon, 04 Feb 2013 14:37:06 +0200, Nikita Kiryanov
<nikita at compulab.co.il> wrote:

> Hi Albert,
> 
> On 02/04/2013 01:57 PM, Albert ARIBAUD wrote:
> >
> > IIRC, you has submitted a fix so that BMP loads would result in
> > correctly aligned fields and thus no need for accessors. Why this
> > change of mind?
>  >
> 
> I did mention that I consider that fix as temporary. I believe this fix
> is better because it addresses the issue everywhere and does so in a
> more maintainable way (does not require the address fix to be duplicated
> everywhere there is a problem).

I actually like the new fix less, as it adds an API where there is no
need of one -- it's not like the implementation of BMP is at risk of
changing. What is the problem in fixing the load address at load time
and then passing this fixed address around?

Amicalement,
-- 
Albert.


More information about the U-Boot mailing list