[U-Boot] common/cmd_bootm.c: prevent running of subcommands before 'bootm start'

Tom Rini trini at ti.com
Mon Feb 4 17:37:29 CET 2013


On Sun, Jan 06, 2013 at 11:04:25PM -0000, Gabor Juhos wrote:

> The execution order of the bootm subcommands is fixed.
> Although here is a sanity check in the state machine
> which should prevent running the subcommands in wrong
> order but it does not catch all possible errors.
> 
> It is possible to run any subcommand without running
> 'bootm start' first which leads to unexpected behaviour.
> For example, running 'bootm loados' without 'bootm start'
> causes a hang:
> 
>     U-Boot> bootm loados
>        XIP Invalid Image ... OK
>     OK
> 
> Add a sanity check to 'do_bootm_subcommand' in order
> to ensure that no subcommands can be executed before
> 'bootm start'.
> 
> After the patch running of any subcommand without running
> 'bootm start' will cause an error like this:
> 
>     U-Boot> bootm loados
>     Trying to execute a command out of order
>     bootm - boot application image from memory
> 
>     Usage:
>     bootm [addr [arg ...]]
>         - boot application image stored in memory
>     ...
> 
> Signed-off-by: Gabor Juhos <juhosg at openwrt.org>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130204/a7345454/attachment.pgp>


More information about the U-Boot mailing list