[U-Boot] [PATCH 1/5] Add bmp_layout module for accessing BMP header data

[Wolfgang Denk]

Dear Igor,

In message <51111C0F.60404 at compulab.co.il> you wrote:
>
> This is a relatively new default setting for the compiler,
> and I think this is the reason why you (still) haven't heard
> about it.
> Also, do you really expect that whoever gets the board bricked
> will go complaining to the mailing list?

Then how do we kno if this is just an anticipated or a real problem?

> Loading of the splash screen has been a part of the U-Boot boot
> sequence for ages, so the test of the feature is roughly just place
> the bmp image in the right place on the storage device, set the
> splashimage variable and reset the board.

Maybe I'm so weird then - I think I have never blindly installed a
splash screen without checking before that it actually works and looks
good, using the "bmp" command...

> Can you propose a feasible (yet not too expensive and not out of
> mainline tree) solution?

Well, if I understand the situation correctly, the problem we have is
that the bitmap address for the splash screen should be aligned to an
even 32 bit boundary + 1.  The address is stored in an environment
variable.

So why don't we implement a callback on that variable that checks
itd's value when it gets set?  We have all the features in place now;
and we can even overwrite such a default setting on boards where it's
not needed / wanted.

So my recommendation is: add a new alignment-checking extension as a
callback to the variable handling code.

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Have you lived in this village all your life?"        "No, not yet."