[U-Boot] [PATCH 08/11] Blackfin: bf60x: add rsi/sdh support

Sonic Zhang sonic.adi at gmail.com
Fri Feb 8 05:33:10 CET 2013


On Thu, Feb 7, 2013 at 6:17 PM, Wolfgang Denk <wd at denx.de> wrote:
> Dear Sonic Zhang,
>
> In message <1360223258-6945-9-git-send-email-sonic.adi at gmail.com> you wrote:
>> From: Sonic Zhang <sonic.zhang at analog.com>
>>
>> Add rsi/sdh support for bf60x.
>
> Checkpatch errors.  Please fix.

OK

>
>> @@ -113,16 +131,19 @@ static int sdh_setup_data(struct mmc *mmc, struct mmc_data *data)
> ...
>> -     int ret = 0;
> ...
>> -     return ret;
>> +     return 0;
>
> If this function can always only return 0, then please make it void.
>
> Please fix globally.
>

Yes

Thanks,

Sonic


More information about the U-Boot mailing list