[U-Boot] [PATCH][v2]powerpc/usb: Fix usb device-tree fix-up

Wolfgang Denk wd at denx.de
Fri Feb 8 06:19:52 CET 2013


Dear Ramneek Mehresh,

In message <1360296886-2444-1-git-send-email-ramneek.mehresh at freescale.com> you wrote:
>
> +				printf("ERROR: wrong usb mode/phy"
> +					" defined!!\n");

1) Please do not split the error message across lines. Quoting
   CodingStyle, Chapter 2: Breaking long lines and strings:

   	However, never break user-visible strings such as printk
	messages, because that breaks the ability to grep for them.

2) There is no formatting needed, so you can use puts() rather
   printf()

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The main thing is the play itself. I swear that greed for  money  has
nothing  to  do with it, although heaven knows I am sorely in need of
money.                                           - Feodor Dostoyevsky


More information about the U-Boot mailing list