[U-Boot] [PATCH v5 18/23] ppc: Enable generic board support

[Scott Wood]

On 02/08/2013 09:12:14 AM, Simon Glass wrote:
> This enables generic board support so that ppc boards can define
> CONFIG_SYS_GENERIC_BOARD.
> 
> Signed-off-by: Simon Glass <sjg at chromium.org>
> ---
> Changes in v5: None
> Changes in v4: None
> Changes in v3: None
> Changes in v2: None
> 
>  arch/powerpc/config.mk            | 3 ---
>  arch/powerpc/include/asm/u-boot.h | 7 +++++++
>  arch/powerpc/lib/Makefile         | 2 ++
>  3 files changed, 9 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/powerpc/config.mk b/arch/powerpc/config.mk
> index bf77090..b706281 100644
> --- a/arch/powerpc/config.mk
> +++ b/arch/powerpc/config.mk
> @@ -29,9 +29,6 @@ PLATFORM_RELFLAGS += -fpic -mrelocatable  
> -ffunction-sections -fdata-sections
>  PLATFORM_CPPFLAGS += -DCONFIG_PPC -D__powerpc__
>  PLATFORM_LDFLAGS  += -n
> 
> -# Move to unified board system later
> -CONFIG_SYS_LEGACY_BOARD := y
> -
>  #
>  # When cross-compiling on NetBSD, we have to define __PPC__ or else  
> we
>  # will pick up a va_list declaration that is incompatible with the
> diff --git a/arch/powerpc/include/asm/u-boot.h  
> b/arch/powerpc/include/asm/u-boot.h
> index 7229a98..951dd6a 100644
> --- a/arch/powerpc/include/asm/u-boot.h
> +++ b/arch/powerpc/include/asm/u-boot.h
> @@ -34,6 +34,11 @@
>   * include/asm-ppc/u-boot.h
>   */
> 
> +#ifdef CONFIG_SYS_GENERIC_BOARD
> +/* Use the generic board which requires a unified bd_info */
> +#include <asm-generic/u-boot.h>
> +#else

Note that a unified bd_info means you're breaking compatibility with  
old, pre-device-tree kernels (including possibly some non-Linux OSes  
that still don't use the device tree) -- in which case why keep it  
around at all?

If you meant for the unified bd_info to be backwards compatible, it's  
missing bi_ip_addr.

-Scott