[U-Boot] [PATCH v3 3/3] Tegra: MMC: Add DT support to MMC driver for all T20 boards

[Simon Glass]

Hi,

On Wed, Feb 13, 2013 at 4:17 PM, Stephen Warren <swarren at wwwdotorg.org> wrote:
> On 02/13/2013 02:44 PM, Tom Warren wrote:
>> tegra_mmc_init() now parses the DT info for bus width, WP/CD GPIOs, etc.
>> Tested on Seaboard, fully functional.
>>
>> Tamonten boards (medcom-wide, plutux, and tec) use a different/new
>> dtsi file w/common settings.
>
>> diff --git a/board/compulab/trimslice/trimslice.c b/board/compulab/trimslice/trimslice.c
>
>> +#ifdef       CONFIG_TEGRA_MMC
>
> It seems a little odd to add this ifdef when it's know that config
> option is enabled in the trimslice config file. I can somewhat
> understand leaving the ifdef in any other board files that already had
> it, but actively adding it here seems strange.
>
>> diff --git a/board/nvidia/common/board.c b/board/nvidia/common/board.c
>
>> @@ -184,7 +187,6 @@ int board_init(void)
>>       /* prepare the WB code to LP0 location */
>>       warmboot_prepare_code(TEGRA_LP0_ADDR, TEGRA_LP0_SIZE);
>>  #endif
>> -
>>       return 0;
>>  }
>
> Unrelated change?
>
>> diff --git a/drivers/mmc/tegra_mmc.c b/drivers/mmc/tegra_mmc.c
>> +static int process_nodes(const void *blob, int node_list[], int count)
>
>> +             /* Mark position as used */
>> +             node_list[i] = -1;
>
> Is this actually necessary?

I don't think it is in this case. It is useful when adding aliases
from multiple compatible IDs, to mark those positions that are already
taken. We don't do that here.

>
> I'll try and test these patches on all the Tegra20 boards I have tomorrow.
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot

Regards,
Simon