[U-Boot] [PATCH 1/2 V3] EXYNOS5: Add function to setup set ps hold

[Minkyu Kang]

Dear Simon Glass,

On 14/02/13 16:24, Simon Glass wrote:
> Hi Minkyu,
> 
> On Wed, Feb 13, 2013 at 11:11 PM, Minkyu Kang <mk7.kang at samsung.com> wrote:
>> Dear Simon Glass,
>>
>> On 14/02/13 15:53, Simon Glass wrote:
>>> Hi,
>>>
>>> On Tue, Feb 12, 2013 at 10:40 PM, Rajeshwari Shinde
>>> <rajeshwari.s at samsung.com> wrote:
>>>> This patch adds a function to set ps_hold data driving value high.
>>>> This enables the machine to stay powered on even after the initial
>>>> power-on condition goes away(e.g. power button).
>>>>
>>>> Acked-by: Simon Glass <sjg at chromium.org>
>>>
>>> Probably should take this out when you rev the version, unless you are
>>> just fixing nits from that person.
>>>
>>>> Signed-off-by: Rajeshwari Shinde <rajeshwari.s at samsung.com>
>>>> ---
>>>> Changes in V2:
>>>>         - Corrected the multi line comment style
>>>> Changes in V3:
>>>>         - Renamed ps hold funstion to set_ps_hold_ctrl and made
>>>>         exynos5_set_ps_hold_ctrl specific for exynos5.
>>>>  arch/arm/cpu/armv7/exynos/power.c        |   16 ++++++++++++++++
>>>>  arch/arm/include/asm/arch-exynos/power.h |    9 +++++++++
>>>>  2 files changed, 25 insertions(+), 0 deletions(-)
>>>>
>>>> diff --git a/arch/arm/cpu/armv7/exynos/power.c b/arch/arm/cpu/armv7/exynos/power.c
>>>> index d4bce6d..e09a678 100644
>>>> --- a/arch/arm/cpu/armv7/exynos/power.c
>>>> +++ b/arch/arm/cpu/armv7/exynos/power.c
>>>> @@ -95,3 +95,19 @@ void set_dp_phy_ctrl(unsigned int enable)
>>>>         if (cpu_is_exynos5())
>>>>                 exynos5_dp_phy_control(enable);
>>>>  }
>>>> +
>>>> +static void exynos5_set_ps_hold_ctrl(void)
>>>> +{
>>>> +       struct exynos5_power *power =
>>>> +               (struct exynos5_power *)samsung_get_base_power();
>>>> +
>>>> +       /* Set PS-Hold high */
>>>> +       setbits_le32(&power->ps_hold_control,
>>>> +                       EXYNOS_PS_HOLD_CONTROL_DATA_HIGH);
>>>> +}
>>>> +
>>>> +void set_ps_hold_ctrl(void)
>>>
>>> Sorry to be a pain, but this has lost the power_ prefix. How about
>>> power_set_ps_hold_ctrl() then?
>>
>> I requested it as the exynos naming rule.
> 
> Do you mean the exynos_ prefix? OK then. I suppose
> exynos_power_set_ps_hold_ctrl() is just getting a bit silly.
> 

No.
exynos's functions are named to set_* and get_*.
There are no prefix.
Because of it's a exynos specific function, and it is placed in power.c.

Thanks.
Minkyu Kang.