[U-Boot] [PATCH v3 1/3] Tegra: fdt: Add/enhance sdhci (mmc) nodes for all T20 DT files

[Tom Warren]

Stephen,

On Wed, Feb 13, 2013 at 5:10 PM, Stephen Warren <swarren at wwwdotorg.org> wrote:
> On 02/13/2013 02:44 PM, Tom Warren wrote:
>> Linux dts files were used for those boards that didn't already
>> have sdhci info populated. Tamonten has their own dtsi file with
>> common sdhci nodes (sourced from Linux).
>
>> diff --git a/dts/Makefile b/dts/Makefile
>> index 922c78c..2ef31e9 100644
>> --- a/dts/Makefile
>> +++ b/dts/Makefile
>> @@ -50,7 +50,7 @@ DT_BIN      := $(obj)dt.dtb
>>  $(DT_BIN): $(TOPDIR)/board/$(VENDOR)/dts/$(DEVICE_TREE).dts
>>       rc=$$( \
>>               cat $< | $(CPP) -P $(DTS_CPPFLAGS) - | \
>> -             { { $(DTC) -R 4 -p 0x1000 -O dtb -o ${DT_BIN} - 2>&1 ; \
>> +             { { $(DTC) -R 4 -p 0x1000 -i $(TOPDIR)/board/$(VENDOR)/dts -i $(TOPDIR)/arch/$(ARCH)/dts -O dtb -o ${DT_BIN} - 2>&1 ; \
>>                   echo $$? >&3 ; } | \
>>                 grep -v '^DTC: dts->dtb  on file' ; \
>>               } 3>&1 1>&2 ) ; \
>
> Shouldn't this be a separate patch?

I can move it into a separate patch in v4.

>
> The one issue with this is that only newer versions of dtc support the
> -i option. The version packaged with most distros won't support it.
> That'll mean something like "MAKEALL -a arm" is going to fail for a lot
> of people without some kind of explicit action (i.e. manually installing
> a newer version of dtc).
>
> That's why I suggested switching from /include/ to #include, and adding
> the include path to the cpp command rather than dtc.
I tried using '#include, and added the 2 dts paths to the DTS_CPPFLAGS
so gcc could find the files, but I got a 'couldn't open
'skeleton.dtsi' error. I didn't want to change tegra20.dtsi to
#include "skeleton.dtsi', and all the other board dts files to
#include ARCH_CPU_DTS, just so we can support the common tamonten
dtsi, so I went back to the DTC include path changes.

There was talk at one time of putting an up-to-date DTC binary in the
U-Boot tools area so everyone would have a consistent level of DT
support. With the small number of boards using DT at this time, I
think we can live with letting people know where to find the latest
DTC release until then.

If someone has a better approach, let me know. Otherwise, I want to
get this into a v4 patch (with the DTC include path changes in it's
own patch so it can be reworked later if needed) today as I'll be gone
until next Weds.

Tom