[U-Boot] [PATCH 07/10] ti814x_evm: add ti814x evm board support

[Tom Rini]

On Wed, Feb 13, 2013 at 09:44:01AM -0500, Matt Porter wrote:

> Add TI814X EVM board directory and config file.
> 
> Signed-off-by: Matt Porter <mporter at ti.com>
[snip]
> +++ b/board/ti/ti814x/evm.h
> @@ -0,0 +1,7 @@
> +#ifndef _EVM_H
[snip]
> +++ b/include/configs/ti814x_evm.h
> @@ -0,0 +1,213 @@
> +#define __CONFIG_TI814X_EVM_H

Needs GPLv2 or later boilerplate.

[snip]
> +#define CONFIG_CMDLINE_TAG		1	/* enable passing of ATAGs  */
> +#define CONFIG_SETUP_MEMORY_TAGS	1
> +#define CONFIG_INITRD_TAG		1	/* for ramdisk support */

Just #define CONFIG_FOO in these cases (and some others that follow)

[snip]
> +	"findfdt="\
> +		"if test $board_name = A335BONE; then " \
> +			"setenv fdtfile am335x-bone.dtb; fi; " \
> +		"if test $board_name = A33515BB; then " \
> +			"setenv fdtfile am335x-evm.dtb; fi; " \
> +		"if test $board_name = A335X_SK; then " \
> +			"setenv fdtfile am335x-evmsk.dtb; fi\0" \

That's not right :)

[snip]
> +/* memtest works on 8 MB in DRAM offset 32MB from start of ram disk*/
> +#define CONFIG_SYS_MEMTEST_START	(PHYS_DRAM_1 + (64 * 1024 * 1024))
> +#define CONFIG_SYS_MEMTEST_END		(CONFIG_SYS_MEMTEST_START \
> +					+ (8 * 1024 * 1024))

This isn't your mistake initially, but this should just be start of
memory to smallest possible config the evm can come with - 4MB.

[snip]
> +#undef CONFIG_NAND_OMAP_GPMC

Just leave it out.

> +#define CONFIG_SYS_BAUDRATE_TABLE	{ 110, 300, 600, 1200, 2400, \
> +4800, 9600, 14400, 19200, 28800, 38400, 56000, 57600, 115200 }

Leave that out and get the generic table.  am335x needs to be updated
for that.

[snip]
> +/* Since SPL did pll and ddr initialization for us,
> + * we don't need to do it twice.
> + */

/*
 * Must be like
 * this.
 */

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130215/d5e2e3be/attachment.pgp>