[U-Boot] [PATCH v3 07/10] usb: mxs: Adapt code for i.MX23 support

Otavio Salvador otavio at ossystems.com.br
Sun Feb 17 21:07:22 CET 2013


On Sun, Feb 17, 2013 at 5:03 PM, Fabio Estevam <festevam at gmail.com> wrote:
> On Sun, Feb 17, 2013 at 4:45 PM, Otavio Salvador
> <otavio at ossystems.com.br> wrote:
>> The i.MX23 just one USB port so we shouldn't mess up with PLL1CTRL and
>
> I think "MX23 has just one USB port" would be better.
>
>> -int ehci_hcd_init(int index, struct ehci_hccr **hccr, struct ehci_hcor **hcor)
>> +static void soc_ehci_hcd_enable_clock(void)
>
> Since this is mxs specific a better name would be: mxs_ehci_hcd_enable_clock

I did it but mxs gives the impression it does mostly the same in both
socs; as the code is mostly different between both I choose soc so it
is clear it is for the soc it is being build.

That was my thought... what do you think?

-- 
Otavio Salvador                             O.S. Systems
E-mail: otavio at ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br


More information about the U-Boot mailing list