[U-Boot] [PATCH v3 07/10] usb: mxs: Adapt code for i.MX23 support
Otavio Salvador
otavio at ossystems.com.br
Sun Feb 17 21:33:52 CET 2013
On Sun, Feb 17, 2013 at 5:11 PM, Fabio Estevam <festevam at gmail.com> wrote:
> On Sun, Feb 17, 2013 at 5:07 PM, Otavio Salvador
> <otavio at ossystems.com.br> wrote:
>
>> I did it but mxs gives the impression it does mostly the same in both
>> socs; as the code is mostly different between both I choose soc so it
>> is clear it is for the soc it is being build.
>>
>> That was my thought... what do you think?
>
> When I read "soc_ehci_hcd_enable_clock" I tend to think that this is
> a core USB function.
>
> When I read "mxs_ehci_hcd_enable_clock" it's clear to me that this
> relates only to mx23/mx28.
>
> Even if it handles the differences between mx23/mx28, I would prefer
> it with a "mxs" prefix.
Fine; I can prepare it for v4; I will wait for Marek's comments to try
to avoid a v5 ;-)
--
Otavio Salvador O.S. Systems
E-mail: otavio at ossystems.com.br http://www.ossystems.com.br
Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br
More information about the U-Boot
mailing list