[U-Boot] [PATCH][v3]powerpc/usb: Fix usb device-tree fix-up

Ramneek Mehresh ramneek.mehresh at freescale.com
Mon Feb 18 05:23:32 CET 2013


Fix USB device-tree fixup to properly handle device-tree fixup and
print appropriate message when wrong/junk "dr_mode" or "phy_type"
are mentioned in hwconfig string

Signed-off-by: Ramneek Mehresh <ramneek.mehresh at freescale.com>
---
Changes for v3:
        - used puts instead of printf
        - error message in one line

 arch/powerpc/cpu/mpc8xxx/fdt.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/powerpc/cpu/mpc8xxx/fdt.c b/arch/powerpc/cpu/mpc8xxx/fdt.c
index 2847094..2db9045 100644
--- a/arch/powerpc/cpu/mpc8xxx/fdt.c
+++ b/arch/powerpc/cpu/mpc8xxx/fdt.c
@@ -167,6 +167,11 @@ void fdt_fixup_dr_usb(void *blob, bd_t *bd)
 				}
 			}
 
+			if (mode_idx < 0 || phy_idx < 0) {
+				puts("ERROR: wrong usb mode/phy defined!!\n");
+				return;
+			}
+
 			dr_mode_type = modes[mode_idx];
 			dr_phy_type = phys[phy_idx];
 
-- 
1.7.11.4




More information about the U-Boot mailing list