[U-Boot] [PATCH v3 9/9] dfu: Support larger than memory transfers.
Marek Vasut
marex at denx.de
Mon Feb 18 13:38:49 CET 2013
Dear Lukasz Majewski,
> Hi Tom,
>
> > On Fri, Nov 30, 2012 at 08:01:12PM +0200, Pantelis Antoniou wrote:
> > > We didn't support upload/download larger than available memory.
> > > This is pretty bad when you have to update your root filesystem for
> > > example.
> > >
> > > This patch removes the limitation (and the crashes when you
> > > transfered any file larger than 4MB).
> > > On top of that reduces the huge dfu buffer from 4MB to just 64K,
> > > which was over the top.
> > >
> > > The sequence number is a 16 bit counter; make sure we
> > > handle rollover correctly. This fixes the wrong transfers for
> > > large (> 256MB) images.
> > >
> > > Also utilize a variable to handle initialization, so that we
> > > don't rely on just the counter sent by the host.
> > >
> > > Signed-off-by: Pantelis Antoniou <panto at antoniou-consulting.com>
> >
> > To be clear, patches 1-8 are good and we should take, but this one
> > means we can't use FAT/EXT* partitions without more work. I would
> > suggest that we set this part aside for a moment and perhaps limit
> > transfers that are larget than RAM to RAW only where we can write in
> > chunks today.
>
> As fair as I remember, some additional work needs to be done with
> composite.c file (to remove nasty #ifdefs). There was a problem with
> newer version of dfu-utils (new handling of descriptors).
>
> It is on top of my queue, but I'm currently buried with other work and
> need to postpone this.
>
> However it is still on the back of my head and I push myself to fix
> this.
Guys, can you just tell me what I should drop from u-boot-usb to submit a pullRQ
with the rest ? Otherwise I'll drop the whole DFU stuff and be done with it.
Best regards,
Marek Vasut
More information about the U-Boot
mailing list