[U-Boot] [PATCH 16/20] Roll crc32 into hash infrastructure

[Wolfgang Denk]

Dear Simon,

In message <CAPnjgZ09okKf0qTnifKOrvg37nEnSNLFzyLBLp+4jt6U_L3RCg at mail.gmail.com> you wrote:
> 
> > -> bloat-o-meter u-boot-before u-boot
> 
> What board is this please?

That was TQM5200S

> This is the generic hashing command. What is happening here is that
> the crc32 command is getting a few more features, more like sha1sum.
> However, this might not be desriable - and in fact this patch changes
> the behaviour of the CRC storage and verify to support using an
> environment variable, and requiring * before the argument when an
> address is required! That needs to be fixed, at least.

Indeed - such a change of user interface must not be done here (though
it does make a lot of sense to use common code for this stuff).

> The intent is to try to unify the hashing/crc features into a single

Understood and appreciayed.

> framework. If you enable only crc32 and nothing else then this has
> quite a cost (0.5KB at present). I think I can reduce this code by
> making the full features of hash.c only available when something more
> than just crc32 is enabled. However, it might involve some #ifdefs...

Actually 0.5 k is quite heavy impact, so I guess the #ifdef's win...


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
But the only way of discovering the limits  of  the  possible  is  to
venture a little way past them into the impossible.
                         - _Profiles of the Future_ (1962; rev. 1973)
                  ``Hazards of Prophecy: The Failure of Imagination''