[U-Boot] [PATCH v3 09/10] mx23_olinuxino: Enable USB support

[Marek Vasut]

Dear Otavio Salvador,

> On Mon, Feb 18, 2013 at 10:38 PM, Marek Vasut <marex at denx.de> wrote:
> > Dear Otavio Salvador,
> > 
> >> On Mon, Feb 18, 2013 at 8:16 PM, Fabio Estevam <festevam at gmail.com> wrote:
> >> > On Sun, Feb 17, 2013 at 4:45 PM, Otavio Salvador
> >> > 
> >> > <otavio at ossystems.com.br> wrote:
> >> >> +#ifdef CONFIG_CMD_USB
> >> >> +       /* Enable LAN9512 */
> >> >> +       gpio_direction_output(MX23_PAD_GPMI_ALE__GPIO_0_17, 1);
> >> >> +#endif
> >> > 
> >> > What about doing like we do with other imx devices and write something
> >> > like:
> >> > 
> >> > gpio_direction_output(MXS_GPIO_NR(0, 17), 1);
> >> > 
> >> > ,where
> >> > 
> >> > #define MXS_GPIO_NR(bank, nr)      ((bank) * 32 + (nr))
> >> > 
> >> > This also aligns with the kernel style.
> >> 
> >> Awesome; I have added it to v5. Thx!
> > 
> > This will bring in quite a lot of inconsistency, will it not?
> 
> Really? why?

Because this will not be used globally with all GPIOs, but only locally for this 
one case. So my suggestion is to postpone this change and do this in one large 
swipe afterwards.

Best regards,
Marek Vasut