[U-Boot] [PATCH 1/1] Add support for new SomIQ-AM37 system on module from MENTOREL Ltd SomIQ-AM37 is based on TI AM37/DM37 processors

[Tom Rini]

On Thu, Jan 24, 2013 at 03:30:00PM +0300, Maxim Podbereznyy wrote:

> From: Maxim Podberezny <lisarden at gmail.com>
> 
> 
> Signed-off-by: Maxim Podberezny <lisarden at gmail.com>

Sorry I missed this at first.

First problem, you don't update the MAINTAINERS file for this board.

Next:
> diff --git a/arch/arm/include/asm/mach-types.h b/arch/arm/include/asm/mach-types.h
> index a676b6d..817e0e6 100644
> --- a/arch/arm/include/asm/mach-types.h
> +++ b/arch/arm/include/asm/mach-types.h
> @@ -1107,6 +1107,7 @@ extern unsigned int __machine_arch_type;
>  #define MACH_TYPE_OMAP5_SEVM           3777
>  #define MACH_TYPE_ARMADILLO_800EVA     3863
>  #define MACH_TYPE_KZM9G                4140
> +#define MACH_TYPE_SOMIQ_AM37           4196

Please do this in the config file as we only change mach-types on
re-sync with the kernel.

[snip]
> +++ b/include/configs/somiq_am37.h
[snip]
> +/*
> + * High Level Configuration Options
> + */
> +#define CONFIG_OMAP		1	/* in a TI OMAP core */

Just #define CONFIG_FOO

> +#define CONFIG_OMAP34XX		1	/* which is a 34XX */
> +#define CONFIG_SOMIQ_AM37	1	/* working with SomIQ-AM37 */

And we don't use CONFIG_SOMIQ_AM37 anywhere, so please don't.

> +#define CONFIG_SYS_BAUDRATE_TABLE	{4800, 9600, 19200, 38400, 57600,\
> +					115200}

Please drop this and use the default table.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130219/53d9d03a/attachment.pgp>