[U-Boot] i.MX6: Add hdmidet command

Stefano Babic sbabic at denx.de
Wed Feb 20 09:36:05 CET 2013


On 20/02/2013 02:21, Eric Nelson wrote:
> On 02/19/2013 06:19 PM, Otavio Salvador wrote:
>> On Tue, Feb 19, 2013 at 10:16 PM, Eric Nelson
>> <eric.nelson at boundarydevices.com> wrote:
>>> On 02/19/2013 05:42 PM, Otavio Salvador wrote:
>>>>
>>>> On Tue, Feb 19, 2013 at 8:03 PM, Eric Nelson
>>>> <eric.nelson at boundarydevices.com> wrote:
>>>>>
>>>>> Hi Otavio,
>>>>>
>>>>>
>>>>> On 02/19/2013 01:30 PM, Otavio Salvador wrote:
>>>>>>
>>>>>>
>>>>>> On Tue, Feb 19, 2013 at 5:12 PM, Eric Nelson
>>>>>> <eric.nelson at boundarydevices.com> wrote:
>>>>>>>
>>>>>>>
>>>>>>> Hi Stefano,
>>>>>>>
>>>>>>> This seems to have gotten lost in the shuffle.
>>>>>>>
>>>>>>> It's showing as "Changes requested" in Patchwork:
>>>>>>>
>>>>>>>            http://patchwork.ozlabs.org/patch/186280/
>>>>>>>
>>>>>>> Is there something you'd like changed?
>>>>>>>
>>>>>>> Please advise,
>>>>>>
>>>>>>
>>>>>>
>>>>>> I'd say to use space between the '+' as done in other code.
>>>>>>
>>>>>
>>>>> I must be dense.
>>>>>
>>>>> Which '+' needs a space?
>>>>
>>>>
>>>> It seems usually when dealing with offsets we have ' + '. Personally I
>>>> think it is clear to read too. But it's not my call so it is up to you
>>>> and Stefano.
>>>>
>>> Gotcha.
>>>
>>> You mean here:
>>>
>>> +{
>>> +       u8 reg = __raw_readb(HDMI_ARB_BASE_ADDR+HDMI_PHY_STAT0);
>>>                                                 ^
>>>
>>> That's the trouble with commenting on the patchwork link...
>>
>> Yes; a space between both macros.
>>
> 
> And a run through checkpatch...
> 
> I am dense today.
> 

Right, sorry for late answer - it is only to fix checkpatch warning,
nothing more. I wll then apply it

Best regards,
Stefano


-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================


More information about the U-Boot mailing list