[U-Boot] [PATCH] Add Boundary Devices Nitrogen6X boards

[Wolfgang Denk]

Dear Eric Nelson,

In message <1361305248-24598-1-git-send-email-eric.nelson at boundarydevices.com> you wrote:

> +static int detect_hdmi(struct display_info_t const *dev)
> +{
> +	return __raw_readb(HDMI_ARB_BASE_ADDR+HDMI_PHY_STAT0) & HDMI_PHY_HPD;
...
> +	reg = __raw_readb(
> +			HDMI_ARB_BASE_ADDR
> +			+HDMI_PHY_CONF0);

etc. etc.

NAK!! We do not allow device access through base address plus offset
notation.  Please use a proper C Struct to access thes device.

Also, are you absolutely sure that the __raw_* accessors are the right
thing to use here?  Are you really sure no memory barriers etc. are
needed here?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The heart is not a logical organ.
	-- Dr. Janet Wallace, "The Deadly Years", stardate 3479.4