[U-Boot] [PATCH 1/2] ARM: bootm: allow skipping fdt memory node fixup

Tom Rini trini at ti.com
Wed Feb 20 15:33:30 CET 2013


On Tue, Feb 19, 2013 at 02:39:45PM -0600, Rob Herring wrote:
> On 02/19/2013 01:26 PM, Wolfgang Denk wrote:
[snip]
> > I dislike this.  If you want to make a property of your device tree
> > "immutable", then you should mark it there as such.  Instead of
> > removing the code here, U-Boot should then check for such a property
> > and leave the value unchanged.
> 
> There is no such way defined to flag that and I'm not going to invent
> one. It's not that the memory node is immutable, but the default should
> not be "needs fixups". No one puts purposely wrong data in their DT. So
> therefore all data should be immutable? What happens when we need to
> fixup immutable data?

It's not so simple.  The first DTs I checked are the am335x ones and I
see they hardcode to 256MB which isn't right, but no one has caught this
since it's blindly fixed up.  So as Wolfgang suggests next, we might
need to go with replacing on 0x0 entries and warning when they don't
match what U-Boot has detected.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130220/01c927c5/attachment.pgp>


More information about the U-Boot mailing list