[U-Boot] [PATCH 12/20] common: Use new numeric setenv functions

[Tom Rini]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 02/24/2013 12:45 PM, Simon Glass wrote:
> Hi Tom,
> 
> On Mon, Feb 18, 2013 at 2:08 PM, Tom Rini <trini at ti.com> wrote:
>> On Wed, Dec 26, 2012 at 10:57:05AM -0800, Simon Glass wrote:
>> 
>>> Use setenv_ulong(), setenv_hex() and setenv_addr() in common/
>>> 
>>> Signed-off-by: Simon Glass <sjg at chromium.org>
>> [snip]
>>> diff --git a/common/cmd_fdos.c b/common/cmd_fdos.c index 
>>> fbee861..5a35cc1 100644 --- a/common/cmd_fdos.c +++ 
>>> b/common/cmd_fdos.c
>> [snip]
>>> @@ -91,8 +90,7 @@ int do_fdosboot(cmd_tbl_t *cmdtp, int flag, 
>>> int argc, char * const argv[]) } flush_cache (load_addr, 
>>> size);
>>> 
>>> -    sprintf(buf, "%x", size); -    setenv("filesize", buf); + 
>>> setenv_hex("filesize", size);
>> 
>> Tab and space mixing in the function.  I'll fix if git am 
>> --whitespace=fix doesn't spot and fix.
> 
> I'll change it back to spaces so that it is consistent, even if 
> checkpatch is upset. There are now 5 patches changed so I will send
> out the whole series again.

Right, we should always be consistent with the file.  From my read of
the series, this was the only one where the file used spaces and the
new insert was tabs, that's what I'm getting at.  I guess the others
didn't stick out as obviously?

- -- 
Tom
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJRKn3kAAoJENk4IS6UOR1WV5gP/Ro7jY8wwUV0O4UMYuFidIVG
9SsElNnJoFaoO+qske9MAR6YknpJNb0hu10ZSZWoA+Db1gGeHMwAydG/F8eYJOad
IE26MJVzzSbjmsQx7UJcRKNPfDLKWcZDUMtDC+2YAjT8PvUDRkOqHKqLc/WxcawM
ytsw7o+6lf7GWYABjjEdJkRqd4kd+lq+l6sQoBk0qqQkergjP4+Si3BN3h77ZupV
8hTA7idf3/6ezKjHB3jyMl5kSFrgEPPdhrRNlaYAFriYKpDIwINHEWAYXgQpAtWW
YSA0CQBKZMVE9liMWy3ZWDFslcfk0i72H3m2IP1kNsyRRx0wuekkUlVONc9AQoVe
x3aSnw3LDt0b3SaGhoMLwVKoL6ZI6IKUfAvJNh/tmc/vNbrDmrot2z8mPd4ccKp4
AfrhlpH4KE8eU6zsVpsVWJ85LHaIBu/5SvW73UFLCDZwwnUUIKCj4A903cweCuoG
i8VrY11OliR/yABz+NRRek7Y8pyBMqq40ES4lZJYrcKXwi0k3OwAraCrA73IZeg3
d50ME2WTBQ+tR0cFfp8BZxTVYxrTpHA2diOHL7rdFRfAlii3Wt6Ee9Zbb+ozir6q
TKfxVqJYmHpTYiEt6CuYpq6GD+wQnWbAYkZw5DbmEeq65UUid/UUPcLhDhEinmg6
wbo0UcLD2TLRqc9IS9fX
=lxH4
-----END PGP SIGNATURE-----