[U-Boot] [PATCH v3 12/16] main: Use autoconf in command line reading

Joe Hershberger joe.hershberger at gmail.com
Wed Feb 27 10:17:02 CET 2013


Hi Simon,

On Tue, Feb 26, 2013 at 10:11 AM, Simon Glass <sjg at chromium.org> wrote:
> Remove #ifdefs in favour of autoconf for this code. This involves removing
> a few unnecessary #ifdefs in headers also.
>
> We have two versions of the code - one that handles command line editing and
> one that is just a simple implementation. Create a new function called
> readline_into_buffer() which calls either cread_line() or the new
> simple_readline(), created to hold the 'simple' code.
>
> The cread_print_hist_list() function is not actually used anywhere, so punt
> it.
>
> Signed-off-by: Simon Glass <sjg at chromium.org>
> ---
> Changes in v3: None
> Changes in v2: None
>
>  common/main.c     | 164 ++++++++++++++++++++++++------------------------------
>  include/command.h |   2 -
>  include/common.h  |   2 -
>  3 files changed, 73 insertions(+), 95 deletions(-)
>

Reviewed-by: Joe Hershberger <joe.hershberger at ni.com>


More information about the U-Boot mailing list