[U-Boot] [PATCH 1/1] socfpga: Adding System Manager driver which will configure the pin mux for real hardware Cyclone V

[Chin Liang See]

Hi Pavel,

On Mon, 2013-07-01 at 12:39 +0200, ZY - pavel wrote:
> Hi!
> 
> > > > --- /dev/null
> > > > +++ b/board/altera/socfpga_cyclone5/pinmux_config.c
> > > > @@ -0,0 +1,213 @@
> > > > +
> > > > +#include "pinmux_config.h"
> > > > +
> > > > +/* pin mux configuration data */
> > > > +unsigned long sys_mgr_init_table[CONFIG_HPS_PINMUX_NUM] = {
> > > > +       0, /* EMACIO0 - Unused */
> > > > +       2, /* EMACIO1 - USB */
> > > > +       2, /* EMACIO2 - USB */
> > > > +       2, /* EMACIO3 - USB */
> > > 
> > > Is this table auto-generated somehow?
> > > 
> > > If so, comment about that would be nice.
> > > 
> > > If not, perhaps we could put more than one entry on line, to make it
> > > shorter?
> > 
> > Yup, its auto generated by tools.
> > I will put comment to note this.
> 
> Thanks!
> 
> You can add Reviewed-by: Pavel Machek <pavel at denx.de> on the next
> version.
> 

Thanks

> In future, would it make sense to separate auto-generated and manual
> parts? It might be good to have something like pinmux_config.i file
> with just inner part of the table...
> 

Sure, I will split them into 2 patches on next version

Chin Liang

> 									Pavel