[U-Boot] [PATCH 3/3] Makefile: fix readelf usage

Albert ARIBAUD albert.u.boot at aribaud.net
Thu Jul 4 14:09:09 CEST 2013


Hi Andreas,

On Sun, 30 Jun 2013 13:15:06 +0200, Andreas Bießmann
<andreas.devel at googlemail.com> wrote:

> Some OS (like OS X) do not provide a generic readelf. We should enforce to use
> the toochain provided readelf instead, to do so use $(CROSS_COMPILE)readelf.
> 
> Signed-off-by: Andreas Bießmann <andreas.devel at googlemail.com>
> ---
>  Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Makefile b/Makefile
> index ba1c10b..446c2f8 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -747,7 +747,7 @@ endif	# config.mk
>  # ARM relocations should all be R_ARM_RELATIVE.
>  checkarmreloc: $(obj)u-boot
>  	@if test "R_ARM_RELATIVE" != \
> -		"`readelf -r $< | cut -d ' ' -f 4 | grep R_ARM | sort -u`"; \
> +		"`$(CROSS_COMPILE)readelf -r $< | cut -d ' ' -f 4 | grep R_ARM | sort -u`"; \
>  		then echo "$< contains relocations other than \
>  		R_ARM_RELATIVE"; false; fi

Acked-by: Albert ARIBAUD <albert.u.boot at aribaud.net>

Tom, do I take this in u-boot-arm and then deliver this later in my PR,
or do you want to pick it directly in mainline?

Amicalement,
-- 
Albert.


More information about the U-Boot mailing list