[U-Boot] Marvell SheevaPlug v2013.04 Refresh (ask for review)

Albert ARIBAUD albert.u.boot at aribaud.net
Mon Jul 8 11:46:36 CEST 2013


Hi DrEagle,

On Mon, 08 Jul 2013 01:41:38 +0200, DrEagle <dreagle at doukki.net> wrote:

> Le 05/07/2013 23:08, Albert ARIBAUD a écrit :
> > Hi Gérald,
> 
> Hello,
> 
> > On Tue, 02 Jul 2013 23:17:51 +0200, DrEagle <dreagle at doukki.net> wrote:
> > 
> >> Hi,
> >>
> >> I have started to rework all the MVSDIO driver, and some more enhancements, to make a cool updated and workable SheevaPlug.
> >> I have take the v2013.04 denx uBoot to base my patchs.
> >>
> >> If you can take a look inside and give me needed feedback.
> >>
> >> I want to precise that I do not easily practice GIT features.
> > 
> > Pease submit patch according to the patch submission guidelines at
> > <http://www.denx.de/wiki/U-Boot/Patches>. Especially, do not send
> > patches to the list as attachments; instead, use 'git format-patch' and
> > 'git send-email'. Also, put the relevant custodians and/or maintainers
> > in Cc: of your mail.
> 
> I'll try to get it rewrote according rules.

Among these rules, please run your patches through checkpatch, or
through patman. Several lines are way beyond 80 chars, for instance,
and either tool would have spotted this.

> I do not get git send-email working.
>
> So I have take appart the patch and will send them separatly.

You should investigate why git send-email fails and try to fix it.

> Regards,
> Gérald

Amicalement,
-- 
Albert.


More information about the U-Boot mailing list