[U-Boot] net, phy: wrong 1000BASE detection with a lan9303 switch
Wolfgang Denk
wd at denx.de
Wed Jul 10 13:15:23 CEST 2013
Dear Heiko,
In message <51DD3D92.8050701 at denx.de> you wrote:
>
> Would this be an acceptable patch for it:
...
> @@ -300,6 +300,10 @@ int genphy_parse_link(struct phy_device *phydev)
> * both PHYs in the link
> */
> gblpa = phy_read(phydev, MDIO_DEVAD_NONE, MII_STAT1000);
> + if (gblpa < 0) {
> + printf ("Could not read MII_STAT1000. Ignoring gigabit capability\n");
> + gblpa = 0;
> + }
> gblpa &= phy_read(phydev,
> MDIO_DEVAD_NONE, MII_CTRL1000) << 2;
Well, this other phy_read() probably needs exactly the same error
handling - and I doubt if we should actually try riding the reg when
the first one failed already?
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Without freedom of choice there is no creativity.
-- Kirk, "The return of the Archons", stardate 3157.4
More information about the U-Boot
mailing list