[U-Boot] [PATCH] image: Don't relocate ramdisk to highmem
Wolfgang Denk
wd at denx.de
Thu Jul 11 11:46:19 CEST 2013
Dear Thierry Reding,
In message <1373500071-6476-1-git-send-email-thierry.reding at gmail.com> you wrote:
>
> The Linux kernel cannot unpack a ramdisk that's stored in high memory.
Can you please be a bit more explicit? Which exact architecture are
you talking about? Can you show a specific example of an error case
for such a system?
> - /* not set, no restrictions to load high */
> - initrd_high = ~0;
> + /* make sure to put ramdisk in low memory */
> + initrd_high = getenv_bootm_low() + getenv_bootm_mapsize();
I don't like to have such a patch (which affects ALL systems) added
unless we understand exactly why we should do that.
Why do you not simply set initrd_high as needed?
Also, when changing the behaviour, you should also update the
comments.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The trouble with our times is that the future is not what it used to
be. - Paul Valery
More information about the U-Boot
mailing list