[U-Boot] [PATCH] net: fec: Remove bogus flush_dcache_range() call

Stefano Babic sbabic at denx.de
Fri Jul 12 09:27:21 CEST 2013


On 11/07/2013 17:23, Marek Vasut wrote:
> Remove incorrectly called and duplicate flush_dcache_range() call
> from fec_mxc driver. The call is not needed, since the caches are
> already flushed in fec_tbd_init(), moreover the second argument should
> be the ending address, not size.
> 
> Signed-off-by: Marek Vasut <marex at denx.de>
> Reported-by: Albert Aribaud <albert.u.boot at aribaud.net>
> Cc: Stefano Babic <sbabic at denx.de>
> Cc: Tom Rini <trini at ti.com>
> ---
>  drivers/net/fec_mxc.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/fec_mxc.c b/drivers/net/fec_mxc.c
> index da95e28..97bf8fe 100644
> --- a/drivers/net/fec_mxc.c
> +++ b/drivers/net/fec_mxc.c
> @@ -560,7 +560,6 @@ static int fec_init(struct eth_device *dev, bd_t* bd)
>  		}
>  		memset(fec->tbd_base, 0, size);
>  		fec_tbd_init(fec);
> -		flush_dcache_range((unsigned)fec->tbd_base, size);
>  	}
>  
>  	/*
> 
Applied to u-boot-imx (fix), thanks !

Best regards,
Stefano Babic


-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================


More information about the U-Boot mailing list