[U-Boot] [PATCH] mx6qsabrelite: Remove mx6qsabrelite code in favor of nitrogen6x

Eric Nelson eric.nelson at boundarydevices.com
Mon Jul 15 06:09:06 CEST 2013


On 07/14/2013 07:58 PM, Otavio Salvador wrote:
> On Sun, Jul 14, 2013 at 11:52 PM, Fabio Estevam <festevam at gmail.com> wrote:
>> Hi Otavio,
>>
>> On Sun, Jul 14, 2013 at 11:44 PM, Otavio Salvador
>> <otavio at ossystems.com.br> wrote:
>>> On Sun, Jul 14, 2013 at 11:40 PM, Fabio Estevam <festevam at gmail.com> wrote:
>>>> From: Fabio Estevam <fabio.estevam at freescale.com>
>>>>
>>>> mx6qsabrelite and nitrogen6q boards are hardware compatible, so let's avoid the
>>>> code duplication and only use the nitrogen6x source code to make board code
>>>> maintainance easier.
>>>>
>>>> Tested booting a mainline device tree kernel on a mx6qsabrelite board.
>>>>
>>>> Signed-off-by: Fabio Estevam <fabio.estevam at freescale.com>
>>>
>>> I think this is a huge improvement I am just not sure about the
>>> environment preserving for sabrelite. I think most people using
>>> sabrelite end using the U-Boot from SPI NOR.
>>
>> I can't say whether SPI NOR or SD card is the most common medium for
>> storing the environment variables for sabrelite, but my main goal here
>> was to try to keep compability with existing code.
>>
>> Currently mx6qsabrelite defines CONFIG_ENV_IS_IN_MMC, so I kept the
>> same here. This patch introduces no change in functional behaviour.
>>
>> If we think CONFIG_ENV_IS_IN_xxx should be changed, then this is
>> something to be handled by a separate patch.
>
> Agreed :-)
>
> Reviewed-by: Otavio Salvador <otavio at ossystems.com.br>
>

+1

We should also add something to the README file though.



More information about the U-Boot mailing list