[U-Boot] [PATCH 1/5] am335x_evm: Make NAND support modular

[Scott Wood]

On 07/17/2013 04:05:37 PM, Scott Wood wrote:
> On 07/09/2013 02:00:06 PM, Justin Waters wrote:
>> Give the user the ability to disable NAND support by defining
>> CONFIG_NO_NAND. This will allow custom hardware to easily support
>> this configuration.
>> 
>> Signed-off-by: Justin Waters <justin.waters at timesys.com>
>> ---
>>  include/configs/am335x_evm.h |   55  
>> ++++++++++++++++++++++++++++--------------
>>  1 file changed, 37 insertions(+), 18 deletions(-)
>> 
>> diff --git a/include/configs/am335x_evm.h  
>> b/include/configs/am335x_evm.h
>> index c5a6d4b..7bcfe2e 100644
>> --- a/include/configs/am335x_evm.h
>> +++ b/include/configs/am335x_evm.h
>> @@ -42,12 +42,39 @@
>> 
>>  #define CONFIG_SYS_CACHELINE_SIZE       64
>> 
>> +#ifdef CONFIG_NO_NAND
>> +#undef CONFIG_NAND
>> +#else
>> +#define CONFIG_NAND
>> +#endif
> 
> Wouldn't it be cleaner to move CONFIG_NAND into boards.cfg, so if you  
> want NAND to be absent, you just add a similar target that doesn't  
> set it?
> 
> Especially if this is for custom hardware, which ought to get its own  
> board.cfg line.

Sigh, as soon as I sent this my mail client decided it would be a good  
idea to show me the other replies from a couple days ago saying the  
same thing.  I need a new mail client...

-Scott