[U-Boot] [PATCH v3 2/7] ARM: OMAP5: USB: Add OMAP5 common USB EHCI information

[Roger Quadros]

On 07/18/2013 08:48 PM, Dan Murphy wrote:
> Dear Roger
> 
> On 07/18/2013 02:10 AM, Roger Quadros wrote:
>> Dan,
>>
>> On 07/17/2013 11:16 PM, Dan Murphy wrote:
>>> * Enable the OMAP5 EHCI host clocks
>>> * Add OMAP5 EHCI register definitions
>>> * Add OMAP5 ES2 host revision
>>>
>>> Signed-off-by: Dan Murphy <dmurphy at ti.com>
>>> ---
>>> v3 - Updated per comments - http://patchwork.ozlabs.org/patch/258230/
>>>
>>>  arch/arm/cpu/armv7/omap5/hw_data.c      |   17 ++++++++++++
>>>  arch/arm/include/asm/arch-omap5/clock.h |    6 +++++
>>>  arch/arm/include/asm/arch-omap5/ehci.h  |   43 +++++++++++++++++++++++++++++++
>>>  arch/arm/include/asm/ehci-omap.h        |    1 +
>>>  drivers/usb/host/ehci-omap.c            |    2 +-
>>>  5 files changed, 68 insertions(+), 1 deletion(-)
>>>  create mode 100644 arch/arm/include/asm/arch-omap5/ehci.h
>>>
>>> diff --git a/arch/arm/cpu/armv7/omap5/hw_data.c b/arch/arm/cpu/armv7/omap5/hw_data.c
>>> index 07b1108..b1be748 100644
>>> --- a/arch/arm/cpu/armv7/omap5/hw_data.c
>>> +++ b/arch/arm/cpu/armv7/omap5/hw_data.c
>>> @@ -414,6 +414,10 @@ void enable_basic_clocks(void)
>>>  		(*prcm)->cm_l4per_gpio6_clkctrl,
>>>  		(*prcm)->cm_l4per_gpio7_clkctrl,
>>>  		(*prcm)->cm_l4per_gpio8_clkctrl,
>>> +#ifdef CONFIG_USB_EHCI_OMAP
>>> +		(*prcm)->cm_clksel_usb_60mhz,
>>> +		(*prcm)->cm_l3init_hsusbtll_clkctrl,
>>> +#endif
>>>  		0
>>>  	};
>>>  
>>> @@ -425,6 +429,9 @@ void enable_basic_clocks(void)
>>>  		(*prcm)->cm_wkup_wdtimer2_clkctrl,
>>>  		(*prcm)->cm_l4per_uart3_clkctrl,
>>>  		(*prcm)->cm_l4per_i2c1_clkctrl,
>>> +#ifdef CONFIG_USB_EHCI_OMAP
>>> +		(*prcm)->cm_l3init_hsusbhost_clkctrl,
>>> +#endif
>>>  		0
>>>  	};
>>>  
>>> @@ -448,6 +455,16 @@ void enable_basic_clocks(void)
>>>  	setbits_le32((*prcm)->cm_wkup_gptimer1_clkctrl,
>>>  			GPTIMER1_CLKCTRL_CLKSEL_MASK);
>>>  
>>> +#ifdef CONFIG_USB_EHCI
>>> +	/* Enable port 2 and 3 clocks*/
>>> +	setbits_le32((*prcm)->cm_l3init_hsusbhost_clkctrl,
>>> +			USB_HOST_HS_CLKCTRL_MASK);
>> For consistency, maybe you should enable all 3 port clocks
>> since you are enabling all 3 TLL clocks below?
> So I thought about this we should enable all 3 clocks since it is a common file and disable the unused clocks in the board file.
> 
> Or we should enable the specific port clocks during ehci_hcd_init in the board file only since it is a board implementation detail.
> 
> Thoughts?

IMHO enabling the clocks based on board is best.

cheers,
-roger