[U-Boot] [PATCH] net: phy: Set SUPPORTED_1000baseX_Half flag in ESTATUS_1000_XHALF case

[Fabio Estevam]

Hi Tom,

On Fri, Jul 19, 2013 at 1:56 PM, Charles Coldwell <coldwell at gmail.com> wrote:
> On Fri, Jul 19, 2013 at 12:55 PM, Tom Rini <trini at ti.com> wrote:
>> On Fri, Jul 19, 2013 at 10:01:34AM -0300, Fabio Estevam wrote:
>>
>>> From: Fabio Estevam <fabio.estevam at freescale.com>
>>>
>>> Commit de1d786e (add support for Xilinx 1000BASE-X phy (GTX)) introduced the
>>> checking for ESTATUS_1000_XHALF, but it incorrectly sets the
>>> SUPPORTED_1000baseX_Full flag in this case.
>>>
>>> Set the SUPPORTED_1000baseX_Half flag instead.
>>>
>>> Signed-off-by: Fabio Estevam <fabio.estevam at freescale.com>
>>
>> So, do we need both patches to fix the problem?
>
> One patch fixes "the" problem; the other fixes another problem we
> haven't seen yet (but will).

I agree with Charles.

Sascha Silbe's patch fixes the regression we noticed on some mx6 boards.

This one is about a different issue and it is not related to the
previous problem.

IMHO we should apply both of them.

Thanks,

Fabio Estevam