[U-Boot] [PATCH V2] fs/ext4: fix log2blksz un-initialized error, by cacaulating its value from blksz

Lan Yixun (dlan) dennis.yxun at gmail.com
Sat Jul 20 02:17:59 CEST 2013


From: "Lan Yixun (dlan)" <dennis.yxun at gmail.com>

The problem here is that uboot can't mount ext4 filesystem with
commit "50ce4c07df1" applied. We use hard-coded "SECTOR_SIZE"(512)
before this commit, now we introduce (block_dev_desc_t *)->log2blksz
to replace this macro. And after we calling do_ls()->fs_set_blk_dev(),
the variable log2blksz is not initialized, which it's not correct.

And this patch try to solve the problem by caculating the value of
log2blksz from variable blksz.

---
the console output after commit "50ce4c07df1" applied:

lt703a # ext4ls nand 3:0
Failed to mount ext2 filesystem...
** Unrecognized filesystem type **

Signed-off-by: Lan Yixun (dlan) <dennis.yxun at gmail.com>
---
 disk/part.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/disk/part.c b/disk/part.c
index d73625c..9400a97 100644
--- a/disk/part.c
+++ b/disk/part.c
@@ -548,6 +548,8 @@ int get_device_and_partition(const char *ifname, const char *dev_part_str,
 			goto cleanup;
 		}
 
+		(*dev_desc)->log2blksz = LOG2((*dev_desc)->blksz);
+
 		info->start = 0;
 		info->size = (*dev_desc)->lba;
 		info->blksz = (*dev_desc)->blksz;
@@ -631,6 +633,8 @@ int get_device_and_partition(const char *ifname, const char *dev_part_str,
 		goto cleanup;
 	}
 
+	(*dev_desc)->log2blksz = LOG2((*dev_desc)->blksz);
+
 	ret = part;
 	goto cleanup;
 
-- 
1.8.2.1



More information about the U-Boot mailing list