[U-Boot] ext4fs: le32_to_cpu() used on a 16-bit field

Tom Rini trini at ti.com
Mon Jul 22 16:11:53 CEST 2013


On Sun, Jul 21, 2013 at 10:53:25AM +0200, Andreas Bie??mann wrote:
> From: Rommel Custodio <sessyargc+uboot at gmail.com>
> 
> Fix reading ext4_extent_header struture on BE machines.
> Some 16 bit fields where converted to 32 bit fields, due to the byte
> swap on BE machines the containing value was corrupted. Therefore
> reading ext4 filesystems on BE machines where broken before.
> 
> Signed-off-by: Rommel Custodio <sessyargc+uboot at gmail.com>
> [sent via git-send-email; rework commit message]
> Signed-off-by: Andreas Bie??mann <andreas.devel at googlemail.com>
> Reviewed-by: Simon Glass <sjg at chromium.org>
> Tested-by: Simon Glass <sjg at chromium.org>
> Tested-by: Lukasz Majewski <l.majewski at samsung.com>

So I gave the changes a review myself based on how the kernel accesses
these fields and agree the changes are correct.  I also did a quick test
on beaglebone black and was able to read (and confirmed crc32) a few
files correctly still.  Applied to u-boot/master with a re-wrapping of
the commit message, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130722/3f2ba1b3/attachment.pgp>


More information about the U-Boot mailing list