[U-Boot] [PATCH 4/7 v9] powerpc : spi flash : Support to start from eSPI with SPL

[Wolfgang Denk]

Dear ying.zhang at freescale.com,

In message <1374571024-15729-4-git-send-email-ying.zhang at freescale.com> you wrote:
> From: Ying Zhang <b40530 at freescale.com>
> 
> This patch introduces SPL to enable a loader stub that being loaded by
> the code from the internal on-chip ROM. It loads the final uboot image
> into DDR, then jump to it to begin execution.
> 
> The SPL's size is sizeable, the maximum size must not exceed the size of L2
> SRAM. It initializes the DDR through SPD code, and copys final uboot image
> to DDR. So there are two stage uboot images:
> 	* spl_boot, 96KB size. The env variables are copied to L2 SRAM, so
> 	that ddr spd code can get the interleaving mode setting in env. It
> 	loads final uboot image from offset 96KB.
> 	* final uboot image, size is variable depends on the functions
> 	enabled.
> 
> Signed-off-by: Ying Zhang <b40530 at freescale.com>

Please fix:

WARNING: Avoid unnecessary line continuations
#225: FILE: drivers/mtd/spi/fsl_espi_spl.c:59:
+       spi_flash_read(flash, CONFIG_CFG_DATA_SECTOR, \

WARNING: Avoid unnecessary line continuations
#235: FILE: drivers/mtd/spi/fsl_espi_spl.c:69:
+       spi_flash_read(flash, offset, code_len, \

WARNING: Avoid unnecessary line continuations
#240: FILE: drivers/mtd/spi/fsl_espi_spl.c:74:
+       flush_cache(CONFIG_SYS_SPI_FLASH_U_BOOT_DST, \

CHECK: No space is necessary after a cast
#242: FILE: drivers/mtd/spi/fsl_espi_spl.c:76:
+                       code_len);
+       uboot = (void *) CONFIG_SYS_SPI_FLASH_U_BOOT_START;


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Every revolutionary idea - in science, politics, art, or  whatever  -
evokes three stages of reaction in a hearer:
  1. It is completely impossible - don't waste my time.
  2. It is possible, but it is not worth doing.
  3. I said it was a good idea all along.