[U-Boot] [PATCH 3/7 v9] powerpc: p1022ds: Enable P1022DS to boot from SD Card with SPL

Wolfgang Denk wd at denx.de
Tue Jul 23 12:47:57 CEST 2013


Dear ying.zhang at freescale.com,

In message <1374571024-15729-3-git-send-email-ying.zhang at freescale.com> you wrote:
> From: Ying Zhang <b40530 at freescale.com>
> 
> Enable p1022ds to start from eSDHC with SPL.
> 
> Signed-off-by: Ying Zhang <b40530 at freescale.com>

Please fix at least the warning:

#243: FILE: board/freescale/p1022ds/spl.c:54:
+       setbits_be32(&gur->pmuxcr,
+               in_be32(&gur->pmuxcr) | MPC85xx_PMUXCR_SD_DATA);

CHECK: Alignment should match open parenthesis
#255: FILE: board/freescale/p1022ds/spl.c:66:
+       NS16550_init((NS16550_t)CONFIG_SYS_NS16550_COM1,
+                       bus_clk / 16 / CONFIG_BAUDRATE);

CHECK: Alignment should match open parenthesis
#265: FILE: board/freescale/p1022ds/spl.c:76:
+       relocate_code(CONFIG_SPL_RELOC_STACK, 0,
+                       CONFIG_SPL_RELOC_TEXT_BASE);

WARNING: Avoid unnecessary line continuations
#283: FILE: board/freescale/p1022ds/spl.c:94:
+       mem_malloc_init(CONFIG_SPL_RELOC_MALLOC_ADDR, \

CHECK: Alignment should match open parenthesis
#322: FILE: board/freescale/p1022ds/tlb.c:100:
+       SET_TLB_ENTRY(1, CONFIG_SYS_INIT_L2_ADDR, CONFIG_SYS_INIT_L2_ADDR_PHYS,
+                       MAS3_SX|MAS3_SW|MAS3_SR, MAS2_G,


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Brain off-line, please wait.


More information about the U-Boot mailing list