[U-Boot] [PATCH 6/7 v9] NAND: TPL : introduce the TPL based on the SPL

Wolfgang Denk wd at denx.de
Tue Jul 23 12:48:55 CEST 2013


Dear ying.zhang at freescale.com,

In message <1374571024-15729-6-git-send-email-ying.zhang at freescale.com> you wrote:
> From: Ying Zhang <b40530 at freescale.com>
> 
> Due to the nand SPL on some board(e.g. P1022DS)has a size limit, it can
> not be more than 4K. So, the SPL cannot initialize the DDR with the SPD
> code. This patch introduces TPL to enable a loader stub that is loaded
> by the code from the SPL. It initializes the DDR with the SPD or other
> operations.
> 
> The TPL's size is sizeable, the maximum size is decided by the memory's
> size that TPL runs. It initializes the DDR through SPD code, and copys
> final uboot image to DDR. So there are three stage uboot images:
> 	* spl_boot, * tpl_boot, * final uboot image
> 
> This patch is on top of the patch:
> 	SPL: Makefile: Build a separate autoconf.mk for SPL
> 
> Signed-off-by: Ying Zhang <b40530 at freescale.com>

ERROR: trailing whitespace
#470: FILE: doc/README.TPL:35:
+board config file. $

CHECK: Alignment should match open parenthesis
#515: FILE: drivers/mtd/nand/fsl_elbc_spl.c:146:
+       nand_spl_load_image(CONFIG_SYS_NAND_U_BOOT_OFFS,
+                               CONFIG_SYS_NAND_U_BOOT_SIZE,

ERROR: code indent should use tabs where possible
#525: FILE: drivers/mtd/nand/fsl_elbc_spl.c:156:
+        nand_spl_load_image(CONFIG_ENV_OFFSET, CONFIG_ENV_SIZE,$

WARNING: please, no spaces at the start of a line
#525: FILE: drivers/mtd/nand/fsl_elbc_spl.c:156:
+        nand_spl_load_image(CONFIG_ENV_OFFSET, CONFIG_ENV_SIZE,$

ERROR: code indent should use tabs where possible
#534: FILE: drivers/mtd/nand/fsl_elbc_spl.c:165:
+        nand_spl_load_image(CONFIG_ENV_OFFSET_REDUND, CONFIG_ENV_SIZE,$

WARNING: please, no spaces at the start of a line
#534: FILE: drivers/mtd/nand/fsl_elbc_spl.c:165:
+        nand_spl_load_image(CONFIG_ENV_OFFSET_REDUND, CONFIG_ENV_SIZE,$

total: 3 errors, 2 warnings, 1 checks, 409 lines checked


Please fix at least the errors and warnings.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
But the only way of discovering the limits  of  the  possible  is  to
venture a little way past them into the impossible.
                         - _Profiles of the Future_ (1962; rev. 1973)
                  ``Hazards of Prophecy: The Failure of Imagination''


More information about the U-Boot mailing list