[U-Boot] [PATCH] video: mxc_ipuv3: fix memory alignment of framebuffer

Marek Vasut marex at denx.de
Fri Jul 26 06:27:10 CEST 2013


Dear Eric Nelson,

> The frame-buffer on i.MX boards needs to be aligned for DMA.
> 
> Signed-off-by: Eric Nelson <eric.nelson at boundarydevices.com>
> ---
>  drivers/video/mxc_ipuv3_fb.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/video/mxc_ipuv3_fb.c b/drivers/video/mxc_ipuv3_fb.c
> index ace226c..ad95831 100644
> --- a/drivers/video/mxc_ipuv3_fb.c
> +++ b/drivers/video/mxc_ipuv3_fb.c
> @@ -416,7 +416,8 @@ static int mxcfb_map_video_memory(struct fb_info *fbi)
>  				    fbi->fix.line_length;
>  	}
> 
> -	fbi->screen_base = (char *)malloc(fbi->fix.smem_len);
> +	fbi->screen_base = (char *)memalign(ARCH_DMA_MINALIGN,
> +					    fbi->fix.smem_len);

You might want to round-up the length too, like I did in the MXS driver.

>  	fbi->fix.smem_start = (unsigned long)fbi->screen_base;
>  	if (fbi->screen_base == 0) {
>  		puts("Unable to allocate framebuffer memory\n");

Best regards,
Marek Vasut


More information about the U-Boot mailing list