[U-Boot] [PATCH v5 7/7] cros: exynos: enable cros-ec for smdk5250

[Simon Glass]

[resent from correct address]

Hi Chander,

On Thu, Jul 25, 2013 at 12:30 AM, Chander Kashyap <
chander.kashyap at linaro.org> wrote:

> On 15 May 2013 15:57, Hung-ying Tyan <tyanh at chromium.org> wrote:
> > This patch initiates cros-ec in board_init() to enable it for smdk5250.
> >
> > This patch depends on the patch in the MMC series that brings in
> exynos5-dt.c.
> > Refer to http://patchwork.ozlabs.org/patch/240084.
> >
> > Signed-off-by: Simon Glass <sjg at chromium.org>
> > Signed-off-by: Vincent Palatin <vpalatin at chromium.org>
> > Signed-off-by: Hung-ying Tyan <tyanh at chromium.org>
> >
> > ---
> > Changes in v5:
> > - Add exynos: tag.
> > - Add dependency description.
> >
> > Changes in v4: None
> > Changes in v3: None
> > Changes in v2:
> > - Moved code from smdk5250.c (non-FDT) to exynos5-dt.c (FDT).
> > - Moved code from smdk5250.h to exynos5250-dt.h.
>
> Sorry for very late reply.
> You are enabling this feature on smdk5250, but adding the
> configuration in exynos5250-dt.h, though exynos5250-dt.h is seems to
> common.
> Though this patch is merged but isnt it possible to submit a patch to
> add configuration macros to smdk5250.h rather than exynos5250-dt.h.
> Or shall i submit the patch for doing so.
>

We had this discuss on the list a month or two back. The idea with
exynos5250-dt.h is that it supports all Exynos5250 boards, and only the
device tree needs to be changes to select the particular features required
for each board. It allows us to check, by building one board config, that
all those boards build correctly. Then we can boot that image on smdk5250
or any other board, only changing the device tree. It is a good 'general'
target for people starting a new port.

But some will want to have their own board config to reduce the size of the
image (removing features they know they don't need).

We talked about creating something like exynos5250-dt-common to hold
options that are common to all boards, so that those boards don't need to
include exynos5250-dt.h. Things like cros_ec could be then be omitted from
exynos5250-dt-common.

Regards,
Simon