[U-Boot] [PATCH] config.mk: Add -Wundef to CFLAGS
Albert ARIBAUD
albert.u.boot at aribaud.net
Tue Jul 30 14:07:16 CEST 2013
Hi Masahiro,
On Tue, 30 Jul 2013 11:57:05 +0900, Masahiro Yamada
<yamada.m at jp.panasonic.com> wrote:
> In U-boot source, some '#if' directives evaluate
> undefined identifiers.
>
> To find and fix them, this commit adds -Wundef to CFLAGS.
>
> Signed-off-by: Masahiro Yamada <yamada.m at jp.panasonic.com>
> ---
> config.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/config.mk b/config.mk
> index f71e145..7a92ae3 100644
> --- a/config.mk
> +++ b/config.mk
> @@ -259,7 +259,7 @@ CPPFLAGS += -I$(TOPDIR)/include
> CPPFLAGS += -fno-builtin -ffreestanding -nostdinc \
> -isystem $(gccincdir) -pipe $(PLATFORM_CPPFLAGS)
>
> -CFLAGS := $(CPPFLAGS) -Wall -Wstrict-prototypes
> +CFLAGS := $(CPPFLAGS) -Wall -Wstrict-prototypes -Wundef
>
> ifdef BUILD_TAG
> CFLAGS += -DBUILD_TAG='"$(BUILD_TAG)"'
Will the patch cause some targets to break? If so, then I personally
would prefer that fixes be provided for at least the trivial cases.
Amicalement,
--
Albert.
More information about the U-Boot
mailing list