[U-Boot] [PATCH] video: add L5F31188 TFT-LCD panel driver

[Hyungwon Hwang]

Hello, Heiko.

I think that function l5f31188_display_enable() is needed to wrap up function l5f31188_display_on().

Function l5f31188_display_enable() is used as an interface to external side, especially to MIPI DSI driver. But function l5f31188_display_on() is used as an internal function in this driver.

Moreover, because they have different input argument types, it cannot be simply replacable.

Thank you for your reply.

Best regards,
Hyungwon Hwang

On Wed, 31 Jul 2013 08:03:28 +0200
Heiko Schocher <hs at denx.de> wrote:

> Hello Hyungwon
> 
> Am 31.07.2013 03:38, schrieb Hyungwon Hwang:
> > This is u-boot driver for L5F31188 panel.
> >
> > I've tested it in the board based on MIPI DSI with EXYNOS4 series,
> > and it worked well.
> >
> > Thanks,
> > Hyungwon Hwang
> >
> > Signed-off-by: Hyungwon Hwang<human.hwang at samsung.com>
> > Signed-off-by: Donghwa Lee<dw09.lee at samsung.com>
> > ---
> >   drivers/video/Makefile   |    1 +
> >   drivers/video/l5f31188.c |  201
> > ++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 202
> > insertions(+) create mode 100644 drivers/video/l5f31188.c
> >
> > diff --git a/drivers/video/Makefile b/drivers/video/Makefile
> > index 68ff34b..997d041 100644
> > --- a/drivers/video/Makefile
> > +++ b/drivers/video/Makefile
> > @@ -38,6 +38,7 @@ COBJS-$(CONFIG_FSL_DIU_FB) += fsl_diu_fb.o
> > videomodes.o COBJS-$(CONFIG_MPC8XX_LCD) += mpc8xx_lcd.o
> >   COBJS-$(CONFIG_PXA_LCD) += pxa_lcd.o
> >   COBJS-$(CONFIG_S6E8AX0) += s6e8ax0.o
> > +COBJS-$(CONFIG_L5F31188) += l5f31188.o
> >   COBJS-$(CONFIG_S6E63D6) += s6e63d6.o
> >   COBJS-$(CONFIG_LD9040) += ld9040.o
> >   COBJS-$(CONFIG_SED156X) += sed156x.o
> > diff --git a/drivers/video/l5f31188.c b/drivers/video/l5f31188.c
> > new file mode 100644
> > index 0000000..a13be0b
> > --- /dev/null
> > +++ b/drivers/video/l5f31188.c
> > @@ -0,0 +1,201 @@
> > +/*
> > + * Copyright (c) 2013 Samsung Electronics Co., Ltd. All rights
> > reserved.
> > + * Hyungwon Hwang<human.hwang at samsung.com>
> > + *
> > + * This program is free software; you can redistribute it and/or
> > + * modify it under the terms of the GNU General Public License as
> > + * published by the Free Software Foundation; either version 2 of
> > + * the License, or (at your option) any later version.
> > + *
> > + * This program is distributed in the hope that it will be useful,
> > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> > + * GNU General Public License for more details.
> 
> Please use for new files SPDX-License-Identifier, thanks.
> 
> > + *
> > + */
> > +
> > +#include<common.h>
> > +#include<asm/arch/mipi_dsim.h>
> > +
> > +#define SCAN_FROM_LEFT_TO_RIGHT 0
> > +#define SCAN_FROM_RIGHT_TO_LEFT 1
> > +#define SCAN_FROM_TOP_TO_BOTTOM 0
> > +#define SCAN_FROM_BOTTOM_TO_TOP 1
> [...]
> > +static void l5f31188_display_enable(struct mipi_dsim_device *dev)
> > +{
> > +	struct mipi_dsim_master_ops *ops = dev->master_ops;
> > +	l5f31188_display_on(dev, ops);
> > +}
> 
> empty function?
> 
> > +
> > +static struct mipi_dsim_lcd_driver l5f31188_dsim_ddi_driver = {
> > +	.name = "l5f31188",
> > +	.id = -1,
> > +
> > +	.mipi_panel_init = l5f31188_panel_init,
> > +	.mipi_display_on = l5f31188_display_enable,
> > +};
> > +
> > +void l5f31188_init(void)
> > +{
> > +
> > exynos_mipi_dsi_register_lcd_driver(&l5f31188_dsim_ddi_driver); +}
> 
> bye,
> Heiko