[U-Boot] [PATCH v7 2/2] console: usb: kbd: To improve TFTP booting performance

[Marek Vasut]

Dear Jim Lin,

> On Fri, 2013-07-19 at 21:53 +0800, Marek Vasut wrote:
> > Dear Jim Lin,
> > 
> > > On Fri, 2013-07-19 at 19:17 +0800, Wolfgang Denk wrote:
> > > > Dear Jim Lin,
> > > > 
> > > > In message <1374226576-13401-2-git-send-email-jilin at nvidia.com> you 
wrote:
> > > > > TFTP booting is slow when a USB keyboard is installed and
> > > > > stdin has usbkbd added.
> > > > > This fix is to change Ctrl-C polling for USB keyboard to every
> > > > > second when NET transfer is running.
> > > > 
> > > > ...
> > > > 
> > > > > +#ifdef CONFIG_CMD_NET
> > > > > +/* The period of time between two calls of usb_kbd_testc(). */
> > > > > +static unsigned long kbd_testc_tms;
> > > > > +#endif

Just use __maybe_unused here to squash the ifdef ;-)

[...]

> > I'll wait for v3. In the meantime, I homestly dont like having such hacks
> > on both sides, but I dont think much can be done about it. Maybe use
> > __maybe_unused for the net_busy_flag to drop the ifdef ?
> 
> I don't quite understand what you wanted me to do.
> Could you give me an example? What to add and what to remove.
> Thanks.
> 
> --nvpublic

Best regards,
Marek Vasut