[U-Boot] [PATCH] spi: Add support SH Queued SPI driver

[Tom Rini]

On Wed, Jul 31, 2013 at 04:50:58PM +0900, Nobuhiro Iwamatsu wrote:

> This patch adds a driver for Renesas SoC's Queued SPI bus.
> This supports with 8 bits per transfer to use with SPI flash.
> 
> Signed-off-by: Kouei Abe <kouei.abe.cp at renesas.com>
> Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj at renesas.com>
[snip]
> +/*
> + * drivers/spi/sh_qspi.c
> + * SH QSPI driver
[snip]

Since "QSPI" also means "Quad SPI", can you please do "SH QSPI (Queued
SPI) driver" here and in the header, so it's clear what Q this is?

> +	/* QSPI initialize */
> +	sh_qspi_writeb(0x08, &ss->regs->spcr);

Can you please #define all of these magic numbers?

Thanks.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130731/e7ef3823/attachment.pgp>