[U-Boot] [Drivers PATCH 14/19] net/macb: workaround for transmission hang issue

[Vipin Kumar]

On 3/1/2013 8:38 AM, Bo Shen wrote:
> Hi All,
>
> On 02/28/2013 08:59 PM, Albert ARIBAUD wrote:
>> On Sun, 3 Feb 2013 12:19:26 +0100, Albert ARIBAUD
>> <albert.u.boot at aribaud.net> wrote:
>>
>>> Hi Vipin,
>>>
>>> On Fri, 2 Nov 2012 23:09:59 +0530, Vipin Kumar<vipin.kumar at st.com>
>>> wrote:
>>>
>>>> From: Shiraz Hashim<shiraz.hashim at st.com>
>>>>
>>>> It is observed on SPEAr320S RMII#1 interface that on transmitting
>>>> packets the MAC dma hangs randomly and constantly showing busy tx-go
>>>> state.
>>>>
>>>> It comes out if this situation only when Transmission is disabled and
>>>> enabled again.
>>>>
>>>> Since it happens randomly and u-boot doesn't require high
>>>> performance we
>>>> disable TE and re-enable it on each transmission. We also change number
>>>> of transmit descriptor to 1 as we would not require more than it,
>>>> further
>>>> it would not alter GMAC notion of transmit descriptor start queue as it
>>>> always point to same descriptor.
>>>>
>>>> Signed-off-by: Shiraz Hashim<shiraz.hashim at st.com>
>>>> ---
>>>> drivers/net/macb.c | 38 ++++++++++++++++++++++++++++++++++----
>>>> 1 file changed, 34 insertions(+), 4 deletions(-)
>
> Tested on Atmel EK board. It works.
>
> Tested-by: Bo Shen <voice.shen at atmel.com>
>
> BTW, would this be implemented as a workaround only for SPEAr320S?
>

Yes, The idea was to implement this only for spear320s
After your tested-by, I am thinking may be I can make a separate 
workaround config which can be enabled by any board using this peripheral.

Is that OK?

Regards
Vipin