[U-Boot] [PATCH 1/3] mx6qsabresd: Fix card detection for invalid card id case

Otavio Salvador otavio at ossystems.com.br
Sun Mar 3 00:08:18 CET 2013


On Sat, Mar 2, 2013 at 7:11 PM, Fabio Estevam <festevam at gmail.com> wrote:
> On Sat, Mar 2, 2013 at 6:49 PM, Otavio Salvador <otavio at ossystems.com.br> wrote:
>
> Please provide a commit log.
>
>> Signed-off-by: Otavio Salvador <otavio at ossystems.com.br>
>> ---
>>  board/freescale/mx6qsabresd/mx6qsabresd.c | 4 +++-
>>  1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/board/freescale/mx6qsabresd/mx6qsabresd.c b/board/freescale/mx6qsabresd/mx6qsabresd.c
>> index 65c4a1a..3c00023 100644
>> --- a/board/freescale/mx6qsabresd/mx6qsabresd.c
>> +++ b/board/freescale/mx6qsabresd/mx6qsabresd.c
>> @@ -151,9 +151,11 @@ int board_mmc_getcd(struct mmc *mmc)
>>                 return !gpio_get_value(USDHC2_CD_GPIO);
>>         case USDHC3_BASE_ADDR:
>>                 return !gpio_get_value(USDHC3_CD_GPIO);
>> -       default:
>> +       case USDHC4_BASE_ADDR:
>>                 return 1; /* eMMC/uSDHC4 is always present */
>
> This looks good.
>
>>         }
>> +
>> +       return 0;
>
> ,but why do we need this?

Fail by default?

-- 
Otavio Salvador                             O.S. Systems
E-mail: otavio at ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br


More information about the U-Boot mailing list