[U-Boot] [PATCH v3 02/10] GPIO: add gpio driver for Orion SoCs

Sebastian Hesselbarth sebastian.hesselbarth at gmail.com
Sun Mar 3 12:36:40 CET 2013


On 02/11/2013 04:39 AM, Prafulla Wadaskar wrote:
>> -----Original Message----- From: Sebastian Hesselbarth
>> [mailto:sebastian.hesselbarth at gmail.com] Sent: 17 January 2013 00:55 To: Sebastian Hesselbarth
>> Cc: u-boot at lists.denx.de; Rabeeh Khoury; Albert Aribaud; Prafulla Wadaskar; Andy Fleming; Joe
>> Hershberger; Daniel Stodden; Luka Perkov Subject: [PATCH v3 02/10] GPIO: add gpio driver for
>> Orion SoCs
>>
>> This adds a gpio driver for Marvell Orion SoCs, i.e. orion5x, kirkwood, dove. This is based on
>> kw_gpio but as gpio capabilities depend heavily on the mpp configuration for dove, it allows to
>> set gpi/gpo capabilities from mpp. This should be compatible with the current kw_gpio and
>> porting mpp of kirkwood and orion5x is appreciated.
>
> Nack, your patch series is for dove, you shouldn't add for orion, unless you are using it. If you
> think this is common framework can be used across the other marvell SoCs, we have strategy to
> name it like mv_***
>
> So you may name this driver as mv_gpio

Prafulla,

I still think that mv_ as a prefix is too short. Remember that Marvell also has
pxa SoCs and with latest SoCs handling of gpio may change dramatically.

We should rather stick to orion_ for Orion5x, Kirkwood, Dove or move to
mvebu_ for above plus Armada XP/370.

Sebastian


More information about the U-Boot mailing list